Skip to content

[Mobile Payments] Update card reader manual URLs #8628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 13, 2023
Merged

[Mobile Payments] Update card reader manual URLs #8628

merged 2 commits into from
Jan 13, 2023

Conversation

@joshheald
Copy link
Contributor

@joshheald joshheald commented Jan 13, 2023 •
edited
Loading

Closes: #8627

Description

We use Stripe URLs to load the card reader manuals. Currently, these links are broken. This PR updates the app to use links that we host these ourselves, so that we can fix issues when required.

The links are:

  • M2: https://woocommerce.com/wp-content/uploads/2022/12/m2_product_sheet.pdf
  • Chipper: https://woocommerce.com/wp-content/uploads/2022/12/c2xbt_product_sheet.pdf
  • WisePad 3: https://woocommerce.com/wp-content/uploads/2022/12/wp3_product_sheet.pdf

Testing instructions

Using a US store

  1. Go to the Menu, then Payments
  2. Open Card Reader Manuals
  3. Open the Chipper manual, and observe that it is the correct manual not a 404
  4. Go back, and open the M2 manual. Again observe it's the correct manual and not a 404

Using a CA store

Repeat, but open and check the WisePad 3 manual.

Screenshots

updated-manuals.mp4
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@joshheald joshheald added type: bug A confirmed bug. feature: mobile payments Related to mobile payments / card present payments / Woo Payments. labels Jan 13, 2023
@joshheald joshheald added this to the 11.9 milestone Jan 13, 2023
@joshheald joshheald marked this pull request as ready for review January 13, 2023 12:38
@joshheald joshheald requested a review from toupper January 13, 2023 12:38
@joshheald joshheald enabled auto-merge January 13, 2023 12:39
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 13, 2023 •
edited
Loading

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8628-6ca5069 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@malinajirka malinajirka self-assigned this Jan 13, 2023
malinajirka
malinajirka approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@malinajirka malinajirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@joshheald joshheald merged commit b69dd5b into trunk Jan 13, 2023
@joshheald joshheald deleted the issue/8627-update-reader-manual-urls branch January 13, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malinajirka malinajirka malinajirka approved these changes

@toupper toupper Awaiting requested review from toupper

Assignees

@malinajirka malinajirka

Labels

feature: mobile payments Related to mobile payments / card present payments / Woo Payments. type: bug A confirmed bug.

Projects

None yet

Milestone

11.9

Development

Successfully merging this pull request may close these issues.

[Mobile Payments] Card reader manuals are pointing to broken links

4 participants

@joshheald @wpmobilebot @malinajirka